[SERVER-58830] GetKMIPRequestParameters' constructor should be explicit Created: 26/Jul/21  Updated: 29/Oct/23  Resolved: 30/Jul/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Spencer Jackson Assignee: Erwin Pe
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Security 2021-08-09
Participants:

 Description   

In C++, constructors which accept a single argument can be automatically used to perform implicit type conversions between the type of the argument and the type class itself. This is frequently undesirable, so unless there is a compelling reason to do so, our codebase requires that constructors with a single argument be marked as "explicit".

 

In kmip_request.h, GetKMIPRequestParameters is defined to be constructable from a std::vector. We should ensure this constructor is marked explicit.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 30/Jul/21 ]

Author:

{'name': 'Erwin Pe', 'email': 'erwin.pe@mongodb.com', 'username': 'erwee'}

Message: SERVER-58830 GetKMIPRequestParameters' constructor should be explicit
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/7654e624b01d799c797d4087004ebbe66c15c85b

Generated at Thu Feb 08 05:45:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.