[SERVER-58915] Implement ReshardingDonorWriteRouter functionality along with unit tests Created: 28/Jul/21  Updated: 29/Oct/23  Resolved: 11/Oct/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.2.0, 5.0.4, 5.1.0-rc2

Type: Task Priority: Major - P3
Reporter: Blake Oler Assignee: Randolph Tan
Resolution: Fixed Votes: 0
Labels: PM-234-M3, PM-234-T-oplog-fetch
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-57666 Convert getDestinedRecipient() in res... Closed
is duplicated by SERVER-58918 Replace getDestinedRecipient() in the... Closed
Gantt Dependency
has to be done before SERVER-58918 Replace getDestinedRecipient() in the... Closed
has to be done after SERVER-58914 Create ReshardingDonorWriteRouter cla... Closed
Related
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.1, v5.0
Sprint: Sharding 2021-08-09, Sharding 2021-09-06, Sharding 2021-09-20, Sharding 2021-10-04, Sharding 2021-10-18
Participants:
Linked BF Score: 0
Story Points: 1

 Description   

Tasks for this ticket

Implementation

  • Implement the constructors and getters in the class.
    • getDestinedRecipient should follow the behavior already defined in the free-standing function here. Note that many of the variables retrieved here will now already exist on the ReshardingDonorWriteRouter class.
    • As part of implementing getDestinedRecipient, use TypeCollectionDonorFields::getTempReshardingNss() rather than calling constructTemporaryReshardingNss(). This is because the donor fields will already have the name constructed, so there's no need to re-calculate it.

Unit tests

  • Change this unit test to test your new class instead of the free-standing getDestinedRecipient() function. The devil is in the details here – if this is intimidating reach out to blake.oler to walk through how this would be done.


 Comments   
Comment by Githook User [ 26/Oct/21 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-58915 Remove unused variables

(cherry picked from commit 618eef6522349a1502b95727313b7967ca6f199a)
Branch: v5.1
https://github.com/mongodb/mongo/commit/b279170319860b50baf7d93bf75f9b111e3ca0b4

Comment by Githook User [ 25/Oct/21 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-58915 Remove unused variables

(cherry picked from commit 618eef6522349a1502b95727313b7967ca6f199a)
Branch: v5.0
https://github.com/mongodb/mongo/commit/a5f9db790c87bd9bab410ee7d8daaa2b938c1d6f

Comment by Githook User [ 25/Oct/21 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-58915 Implement ReshardingDonorWriteRouter functionality along…

(cherry picked from commit 800c6d40912751e272853e383f4c4bf1f00e5c88)
Branch: v5.0
https://github.com/mongodb/mongo/commit/075ed1ea34178e3328620e942941e43e85b5b567

Comment by Githook User [ 11/Oct/21 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-58915 Remove unused variables
Branch: master
https://github.com/mongodb/mongo/commit/618eef6522349a1502b95727313b7967ca6f199a

Comment by Githook User [ 21/Sep/21 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-58915 Implement ReshardingDonorWriteRouter functionality along…
Branch: master
https://github.com/mongodb/mongo/commit/800c6d40912751e272853e383f4c4bf1f00e5c88

Comment by Blake Oler [ 23/Aug/21 ]

lamont.nelson max.hirschhorn to reassign

Generated at Thu Feb 08 05:45:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.