|
The jstests/sharding/txn_two_phase_commit_write_concern.js test passes locally for me in the sharding_multiversion.yml suite.
python buildscripts/resmoke.py run --suite=sharding_multiversion jstests/sharding/txn_two_phase_commit_write_concern.js -j4 --repeatTests=20
|
It looks like the issue had been enableCoordinateCommitReturnImmediatelyAfterPersistingDecision() in jstests/sharding/libs/sharded_transactions_helpers.js wasn't actually setting coordinateCommitReturnImmediatelyAfterPersistingDecision to true. This meant TransactionCoordinatorService::coordinateCommit() was returning a future that only becomes ready after the transaction coordination is entirely finished rather than when the transaction coordinator's decision is persisted according to the level of the commitTransaction command's write concern.
The changes from 4900921 as part of SERVER-58942 fixed this issue in enableCoordinateCommitReturnImmediatelyAfterPersistingDecision(). I think I should be able to go ahead and remove the disabled_due_to_server_58295 tag without doing any additional work.
|