[SERVER-58963] Re-enable txn_two_phase_commit_write_concern.js in multiversion suites Created: 30/Jul/21  Updated: 29/Oct/23  Resolved: 04/Aug/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Pierlauro Sciarelli Assignee: Max Hirschhorn
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from SERVER-58351 Fix disabled Sharding tests failing i... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

The test was disabled as part of SERVER-58295 and it should be re-enabled now that the FCV constants have been updated.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 04/Aug/21 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-58963 Run txn_two_phase_commit_write_concern.js w/ mixed version.
Branch: master
https://github.com/mongodb/mongo/commit/94b2fb7a709d1d1c72f0f4aedf5ffd4b9c14498b

Comment by Max Hirschhorn [ 03/Aug/21 ]

The jstests/sharding/txn_two_phase_commit_write_concern.js test passes locally for me in the sharding_multiversion.yml suite.

python buildscripts/resmoke.py run --suite=sharding_multiversion jstests/sharding/txn_two_phase_commit_write_concern.js -j4 --repeatTests=20

It looks like the issue had been enableCoordinateCommitReturnImmediatelyAfterPersistingDecision() in jstests/sharding/libs/sharded_transactions_helpers.js wasn't actually setting coordinateCommitReturnImmediatelyAfterPersistingDecision to true. This meant TransactionCoordinatorService::coordinateCommit() was returning a future that only becomes ready after the transaction coordination is entirely finished rather than when the transaction coordinator's decision is persisted according to the level of the commitTransaction command's write concern.

The changes from 4900921 as part of SERVER-58942 fixed this issue in enableCoordinateCommitReturnImmediatelyAfterPersistingDecision(). I think I should be able to go ahead and remove the disabled_due_to_server_58295 tag without doing any additional work.

Generated at Thu Feb 08 05:45:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.