[SERVER-59010] Fix SSL off build, OCSPManager shouldn't be used when ssl = off Created: 02/Aug/21  Updated: 29/Oct/23  Resolved: 29/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.10

Type: Bug Priority: Major - P3
Reporter: Renan Castro Assignee: Spencer Jackson
Resolution: Fixed Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Gantt End to End
Related
is related to SERVER-50050 Build with --ssl=off fails Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Security 2021-08-23, Security 2021-09-06, Security 2021-09-20, Security 2021-10-04
Participants:

 Description   

When building with SSL=off, latest 4.4.4 release doesn't compile with the following error:

src/mongo/db/db.cpp:340: error: undefined reference to 'mongo::OCSPManager::startThreadPool()'
src/mongo/util/net/ocsp/ocsp_manager.h:49: error: undefined reference to 'mongo::OCSPManager::OCSPManager()'
collect2: error: ld returned 1 exit status
scons: *** [build/opt/mongo/mongod] Error 1
scons: building terminated because of errors.
build/opt/mongo/mongod failed: Error 1

OCSPManager thread pool probably shouldn't be started when SSL is off, as this class is not compiled in the presence of such an option.

Also some info here: https://developer.mongodb.com/community/forums/t/failure-to-build-mongodb-4-4-4/100231

This is blocking Meteor build of MongoDB, as we do use a small binary without SSL for development easiness.

The last version it was working is : MONGODB_VERSION='4.2.8'

Original Summary

Ssl off build fails

Original Description

A build of MongoDB of install-core with --ssl=off does not work due to missing ifdefs to exclude SSL related code.



 Comments   
Comment by Githook User [ 29/Sep/21 ]

Author:

{'name': 'Renan Castro', 'email': 'renanccastro@gmail.com', 'username': 'renanccastro'}

Message: SERVER-59010 Fix SSL off build, OCSPManager shouldn't be used when ssl = off
Branch: v4.4
https://github.com/mongodb/mongo/commit/469c36d7b782256a854452f828627d1026d5c18e

Comment by Spencer Jackson [ 29/Sep/21 ]

I can confirm that this PR makes sense to merge, and fixes static builds with ssl=off. It seems that additional work is required to make dynamic builds function, which was performed in r5.0.0 with SERVER-50050. I've approved a backport of SERVER-50050, which I'll merge at the same time as this patch in order to fix both dynamic and static builds.

Generated at Thu Feb 08 05:46:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.