[SERVER-59054] Enforce timeouts for generated fuzzer tasks Created: 03/Aug/21  Updated: 29/Oct/23  Resolved: 09/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.4, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: David Bradford (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
causes SERVER-59295 Increase task timeout for aggregation... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0
Sprint: DAG 2021-08-23
Participants:
Linked BF Score: 50
Story Points: 2

 Description   

Here's an example task definition in the generated JSON from this task

        {
            "name": "aggregation_expression_multiversion_fuzzer_0_enterprise-rhel-80-64-bit-dynamic-required",
            "commands": [
                {
                    "func": "git get project no modules"
                },
                {
                    "func": "do setup"
                },
                {
                    "func": "configure evergreen api credentials"
                },
                {
                    "func": "do multiversion setup"
                },
                {
                    "func": "setup jstestfuzz"
                },
                {
                    "func": "run jstestfuzz",
                    "vars": {
                        "jstestfuzz_vars": "--numGeneratedFiles 5 ",
                        "npm_command": "agg-expr-fuzzer"
                    }
                },
                {
                    "func": "run generated tests",
                    "vars": {
                        "continue_on_failure": "false",
                        "resmoke_args": "--suites=generational_fuzzer --mongodSetParameters='{logComponentVerbosity: {command: 2}}'",
                        "resmoke_jobs_max": "1",
                        "should_shuffle": "false",
                        "require_multiversion": "true",
                        "timeout_secs": "1800",
                        "task": "aggregation_expression_multiversion_fuzzer",
                        "gen_task_config_location": "enterprise-rhel-80-64-bit-dynamic-required/64a119b69ce7ae34ec7eac15e52ad1a08beb5b08/generate_tasks/build_variant_gen-mongodb_mongo_master_enterprise_rhel_80_64_bit_dynamic_required_64a119b69ce7ae34ec7eac15e52ad1a08beb5b08_21_08_03_08_34_20.tgz"
                    }
                }
            ],
            "depends_on": [
                {
                    "name": "archive_dist_test_debug"
                }
            ]
        },

timeout_secs does not appear to be used. The agent log for the actual task shows that the timeout is 2h for all commands and globally.

For non-generated tasks, this is not a problem. The "run tests" function in evergreen.yml calls "update_task_timeout_expansions", whereas the "run generated tests" function does not.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 21/Sep/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-59054: Enforce timeouts for generated fuzzer tasks

(cherry picked from commit 8b6082cc0c71dab86443b101eac79731aea8a356)
Branch: v5.0
https://github.com/mongodb/mongo/commit/88d43bfc78c6f507b1524eee2c2f9dfdb44f2342

Comment by Githook User [ 09/Aug/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-59054: Enforce timeouts for generated fuzzer tasks
Branch: master
https://github.com/mongodb/mongo/commit/8b6082cc0c71dab86443b101eac79731aea8a356

Comment by Brooke Miller [ 06/Aug/21 ]

We discussed that for fuzzer tasks we will indeed use the "timeout_secs" value.

Comment by Robert Guo (Inactive) [ 04/Aug/21 ]

Ah ok.. thanks for checking David. Feel free to close this as works as designed, since there's unlike to be user-facing impact. (My experiment can be run with a non-fuzzer task)

Generated at Thu Feb 08 05:46:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.