[SERVER-59213] Clean up and consolidate the logic around MoveChunkRequest::appendAsCommand() Created: 10/Aug/21  Updated: 29/Oct/23  Resolved: 10/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Paolo Polato Assignee: Paolo Polato
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding EMEA 2021-08-23
Participants:

 Description   

The method could benefit from two simple refactoring operations:

  • remove the logic that ensure interoperability with version 3.4 (this would allow to drop a parameter from the function signature)
  • embed the logic to generate the writeConcern value (as it is required by any client invoking MoveChunkRequest::appendAsCommand()).


 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 10/Aug/21 ]

Author:

{'name': 'Paolo Polato', 'email': 'paolo.polato@mongodb.com', 'username': 'ppolato'}

Message: SERVER-59213 Refactoring MoveChunkRequest::appendAsCommand()
Branch: master
https://github.com/mongodb/mongo/commit/1242fd1ee165d803fde22974aa232ebaec342c0e

Generated at Thu Feb 08 05:46:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.