[SERVER-59224] Remove more owned raw pointers from QueryPlanner code Created: 10/Aug/21 Updated: 18/Apr/22 Resolved: 18/Apr/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | David Percy |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | neweng, quick-tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 23 | ||||||||||||||||
| Description |
|
The QueryPlanner still has places where it uses owned raw pointers which should be modernized to use std::unique_ptr:
QuerySolutionNode also holds its children by raw pointer rather than std::unique_ptr, but fixing this is tracked by related ticket |
| Comments |
| Comment by David Percy [ 18/Apr/22 ] |
|
I ended up addressing this as part of |
| Comment by Milena Ivanova [ 19/Aug/21 ] |
|
As part of this BF-21396 some row pointers will be replaced with unique_ptr, but we could not reproduce the bug and hence, it is not sure the problem is completely solved. |