[SERVER-59301] Fix set_step_params.js test to match the signature of the waitInHello fail point Created: 11/Aug/21  Updated: 29/Oct/23  Resolved: 22/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 4.2.15
Fix Version/s: 4.2 Required

Type: Bug Priority: Major - P3
Reporter: Andrew Shuvalov (Inactive) Assignee: Andrew Shuvalov (Inactive)
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2021-08-23
Participants:
Linked BF Score: 130

 Description   

Apparently waitInHello fail point signature change made is somewhat incompatible with existing test set_step_params.js. However mind that the test started failing in 2020 a year before this fail point refactoring, so the logic there was not strong anyway.

At least we need to adjust the test to the fail point change, which may not be a 100% fix but at least should make it better, then we can revisit the race.

Old signature:
MONGO_FAIL_POINT_PAUSE_WHILE_SET_OR_INTERRUPTED(opCtx, waitInHello);
new one:
boost::optional<Milliseconds> sleepTimeout;
MONGO_FAIL_POINT_BLOCK(waitInHello, customArgs)

{ sleepTimeout = handleHelloFailPoint(customArgs.getData(), cmdObj); }

if (MONGO_unlikely(sleepTimeout))

{ sleepForDurationOrUntilShutdown(*sleepTimeout); }

 Comments   
Comment by Githook User [ 21/Aug/21 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-59301 fixed waitInHello fail injection and tests using it
Branch: v4.2
https://github.com/mongodb/mongo/commit/3529af5e853b2f13ab34233a561c619b4d1efe22

Comment by Githook User [ 20/Aug/21 ]

Author:

{'name': 'Andrew Shuvalov', 'email': 'andrew.shuvalov@mongodb.com', 'username': 'shuvalov-mdb'}

Message: SERVER-59301 fixed waitInHello fail injection and tests using it
Branch: andrew.shuvalov/SERVER-59301-0820-fix-test-set-steps-44
https://github.com/mongodb/mongo/commit/f3d9e8673f55501fa9b1389216d3b9e1beea6c5c

Generated at Thu Feb 08 05:46:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.