[SERVER-59591] LockerNoop::isW() always returns true allowing multiple operations think they are holding the global exclusive lock at the same time Created: 25/Aug/21 Updated: 29/Oct/23 Resolved: 27/Aug/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.4, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Gregory Wlodarek | Assignee: | Gregory Wlodarek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||
| Backport Requested: |
v5.0
|
||||||||||||||||||||||||||||
| Sprint: | Execution Team 2021-09-06 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 137 | ||||||||||||||||||||||||||||
| Description |
|
This is problematic because the profile command on mongos uses a LockerNoop and CollectionCatalog::write(). |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 20/Sep/21 ] |
|
Author: {'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}Message: (cherry picked from commit 329b23bc73b8f143375b5c577c7d787c08699275) |
| Comment by Githook User [ 27/Aug/21 ] |
|
Author: {'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}Message: |
| Comment by Gregory Wlodarek [ 26/Aug/21 ] |
|
I've filed |
| Comment by Gregory Wlodarek [ 26/Aug/21 ] |
|
daniel.gottlieb, I haven't looked into that. Originally I thought that LockerNoop was used to make unit testing easier, but this made me realize it's easy to make unintentional changes that affect things outside of that. We should probably reevaluate using LockerNoop outside of unit testing. |
| Comment by Daniel Gottlieb (Inactive) [ 26/Aug/21 ] |
|
Not exactly pertinent question: why does a mongos use a LockerNoop? |
| Comment by Gregory Wlodarek [ 25/Aug/21 ] |
|
milkie, since I do agree that |
| Comment by Eric Milkie [ 25/Aug/21 ] |
|
Yes, this is |