[SERVER-59597] Remove dead code from SBE Scan operator Created: 25/Aug/21 Updated: 29/Oct/23 Resolved: 09/Nov/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Ian Boros | Assignee: | Neil Shweky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2021-11-01 |
| Participants: |
| Description |
|
In sbe::ScanStage, there is some logic for dealing with the case where _coll is nullptr, though it appears to be the case that we always throw an exception before we reach these cases. We should remove this dead code, and similar elsewhere in the file and replace it with a MONGO_UNREACHABLE_TASSERT where appropriate. As part of this work we should also see if the analogous code in ix_scan.cpp is dead as well. |
| Comments |
| Comment by Githook User [ 04/Nov/21 ] |
|
Author: {'name': 'Neil Shweky', 'email': 'neilshweky@gmail.com', 'username': 'Neilshweky'}Message: |