[SERVER-59672] Fix stopping replication in step_down_during_draining3.js Created: 30/Aug/21  Updated: 29/Oct/23  Resolved: 10/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.11, 5.0.4, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Moustafa Maher Assignee: Moustafa Maher
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0, v4.4
Sprint: Repl 2021-09-06, Repl 2021-09-20
Participants:
Linked BF Score: 35

 Description   

Test enable 'rsSyncApplyStop' fail point before inserting documents to the primary, but we don't wait for the fail point to be enabled, so there was a race condition and the replication happened before the fail point got enabled.

 

Use stopReplicationOnSecondaries(rst) util function instead.



 Comments   
Comment by Githook User [ 18/Oct/21 ]

Author:

{'name': 'Moustafa Maher Khalil', 'email': 'm.maher@mongodb.com', 'username': 'moustafamaher'}

Message: SERVER-59672 change rsSyncApplyStop failpoint's enabled log
Branch: v5.0
https://github.com/mongodb/mongo/commit/be510bb572fe68579df27019e3d5be87ac546514

Comment by Githook User [ 18/Oct/21 ]

Author:

{'name': 'Moustafa Maher Khalil', 'email': 'm.maher@mongodb.com', 'username': 'moustafamaher'}

Message: SERVER-59672 change rsSyncApplyStop failpoint's enabled log
Branch: v4.4
https://github.com/mongodb/mongo/commit/e7aaf52d138c60e6b9fb7a3566c48469c4bfd3dc

Comment by Githook User [ 18/Oct/21 ]

Author:

{'name': 'Moustafa Maher Khalil', 'email': 'm.maher@mongodb.com', 'username': 'moustafamaher'}

Message: SERVER-59672 change rsSyncApplyStop failpoint's enabled log
Branch: master
https://github.com/mongodb/mongo/commit/8ffe1e780d977f3e6a3f17c36f8273a0193df85c

Comment by Githook User [ 09/Oct/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-59672 Fix stopping replication in step_down_during_draining3.js
Branch: v5.0
https://github.com/mongodb/mongo/commit/80895a5c2ac73d2ac18efb2efecfc1b242259874

Comment by Githook User [ 09/Oct/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-59672 Fix stopping replication in step_down_during_draining3.js
Branch: v4.4
https://github.com/mongodb/mongo/commit/f92e0d318ab17f730c49ffdb79f1a64d43fbabd3

Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 08/Sep/21 ]

Author:

{'name': 'Moustafa Maher', 'email': 'm.maher@10gen.com', 'username': 'moustafamaher'}

Message: SERVER-59672 Fix stopping replication in step_down_during_draining3.js
Branch: master
https://github.com/mongodb/mongo/commit/7d222de143cd6ebb1d0613120d2219ba8e3ff41e

Generated at Thu Feb 08 05:47:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.