[SERVER-59696] Include SBE plan cache as part of cache size metric Created: 31/Aug/21 Updated: 29/Oct/23 Resolved: 02/Feb/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Joshua Lapacik (Inactive) | Assignee: | Alexander Ignatyev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | QO 2021-11-01, QO 2021-11-15, QO 2021-11-29, QO 2021-12-13, QO 2021-12-27, QO 2022-01-10, QO 2022-01-24, QO 2022-02-07 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
Right now the server metric `query.planCacheTotalSizeEstimateBytes` refers to the classic plan cache. We need to update this metric when we introduce the SBE plan cache. Three options proposed by david.storch:
|
| Comments |
| Comment by Githook User [ 02/Feb/22 ] | |||||||
|
Author: {'name': 'joshua', 'email': '80741223+jlap199@users.noreply.github.com', 'username': 'jlap199'}Message: | |||||||
| Comment by Joshua Lapacik (Inactive) [ 01/Nov/21 ] | |||||||
|
After discussion, we've decided not to change the current implementation which reports the sum of both plan caches in the `query.planCacheTotalSizeEstimateBytes` metric. Just need to add a test. | |||||||
| Comment by David Storch [ 31/Aug/21 ] | |||||||
|
Anton proposed the following, which is similar to option (3):
I'm a little unsure if we should go with this suggestion, however, since it changes the format of the planCacheTotalSizeEstimateBytes serverStatus metric. We will have to determine whether this is an acceptable change. The other reason for my hesitation is that, in the long run, it should be unusual to have both SBE and classic plan caches. As SBE starts to handle more and more queries, the classic plan cache (and indeed the entire classic engine) should be used less and less. Eventually we would have to change the format once again when phasing out the classic engine. |