[SERVER-59716] Re-enable Sharding tests with the "disabled_due_to_server_58295" tag Created: 01/Sep/21  Updated: 29/Oct/23  Resolved: 20/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Vishnu Kaushik Assignee: Luis Osta (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-59737 Remove the "disabled_due_to_server_58... Closed
Problem/Incident
Related
is related to SERVER-58351 Fix disabled Sharding tests failing i... Closed
is related to SERVER-58295 Temporarily disable multiversion test... Closed
is related to SERVER-58296 Re-enable multiversion tests from SER... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2021-09-20, Sharding 2021-10-04
Participants:
Linked BF Score: 158
Story Points: 1

 Description   

Please re-enable the following tests that were disabled in SERVER-58295:

jstests/multiVersion/genericSetFCVUsage/2_test_launching_cluster.js
jstests/multiVersion/genericSetFCVUsage/add_invalid_shard.js
jstests/multiVersion/genericSetFCVUsage/migration_between_mixed_FCV_mixed_version_mongods.js
jstests/multiVersion/migration_between_mixed_version_mongods.js
jstests/sharding/rewrite_state_change_errors.js

There may be other tests belonging to sharding. Please grep for "disabled_due_to_server_58295" to identify and re-enable them.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 20/Sep/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-59716 Removed "disabled_due_to_server_58295" tag from add_invalid_shard
Branch: master
https://github.com/mongodb/mongo/commit/292f84616937c9cbc6b7b82ab1870d794e1be028

Comment by Luis Osta (Inactive) [ 15/Sep/21 ]

vishnu.kaushik I think you were in the right track! I appreciate the guidance. Upon investigation, it seems that the error is originating from a CLI error due to changes that were part of https://jira.mongodb.org/browse/PM-797

Comment by Luis Osta (Inactive) [ 14/Sep/21 ]

Ah okay, thanks! I really do appreciate it I wouldn't have caught this otherwise. I'll look into it. It could very well related depending on how its not getting passed

Comment by Vishnu Kaushik [ 14/Sep/21 ]

SERVER-58947 deals with other params as well. I just thought whether or not the --replset param was being passed might have something to do with it.

This is just a guess, I could very well be wrong but I just wanted to let you know!

Comment by Luis Osta (Inactive) [ 14/Sep/21 ]

vishnu.kaushik I'll have to investigate, I think its a similar problem but I don't think its related to that server ticket specifically (though I could be wrong). Since that one deals with log verbosity and this is about the server being configured as a standalone instead of a replica set.

 

What makes you think its caused by SERVER-58947

Comment by Githook User [ 09/Sep/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-59716 Re-enable Sharding tests with the "disabled_due_to_server_58295" tag
Branch: master
https://github.com/mongodb/mongo/commit/d8634cee813f0c27fecdd69c0089cc2394ca2c23

Comment by Luis Osta (Inactive) [ 09/Sep/21 ]

Okay sounds good I'll keep it all in this ticket

Comment by Vishnu Kaushik [ 09/Sep/21 ]

luis.osta I think it's a good idea to re-enable the tests that can be re-enabled, so that we can increase our test coverage immediately.

As far as the other two problematic tests go, a separate ticket is fine so long as you mark the new ticket as "is depended on by" SERVER-59737. It might just be easier then to use a separate commit but the same ticket number instead (the current ticket, SERVER-59716). Thanks!

Comment by Luis Osta (Inactive) [ 09/Sep/21 ]

steven.vannelli Would it be worthwhile to re-enable all that can be enabled? And then on a separate ticket or a separate commit re-enable those two problem ones?

Comment by Steven Vannelli [ 09/Sep/21 ]

Thanks for the update luis.osta!

Comment by Luis Osta (Inactive) [ 09/Sep/21 ]

steven.vannelli I'm working on this now, there are two of these tests are still failing even though SERVER-58295 is done. These are:

  • jstests/sharding/rewrite_state_change_errors.js
  • jstests/multiVersion/genericSetFCVUsage/add_invalid_shard.js

 I'll continue to investigating

Comment by Githook User [ 09/Sep/21 ]

Author:

{'name': 'Simon Gratzer', 'email': 'simon.gratzer@mongodb.com'}

Message: Revert "SERVER-59716 Removed usage of "disabled_due_to_server_58295" tag"
Branch: master
https://github.com/mongodb/mongo/commit/8c4c466acd6fb8d96bbfa9f0ddc5df7de9fdbe6f

Comment by Githook User [ 08/Sep/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-59716 Removed usage of "disabled_due_to_server_58295" tag
Branch: master
https://github.com/mongodb/mongo/commit/b923a3440e471d6da67cf91dacee2d76c330ed2a

Generated at Thu Feb 08 05:47:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.