[SERVER-59763] remove subtle typo that happens to compile Created: 03/Sep/21  Updated: 29/Oct/23  Resolved: 03/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by SERVER-57334 Create desugaring namespace for Docum... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2021-09-20
Participants:

 Description   

caused by SERVER-57334
Here are two lines of document_source_densify.cpp:

508:            _current = addValues(stdx::get<Value>(*_current), _range.getStep());
509:            _current = stdx::get<Value>(*_current), _range.getStep();

I'm pretty sure 509 is a corrupted copy of 508.
This compiles but throws a fatal warning on my virtual workstation having to do with memcpy of a string onto itself. Details unimportant but the good news is that it's caught.

(Some more detail here in this comment: https://jira.mongodb.org/browse/SERVER-57334?focusedCommentId=4038170&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-4038170
)



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 03/Sep/21 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-59763 remove subtle typo that happens to compile
Branch: master
https://github.com/mongodb/mongo/commit/d3c27db84dafbeb65eedaf16a288785528d12ed0

Generated at Thu Feb 08 05:48:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.