[SERVER-5977] switch from list<>.sort() to sort(vector<>) Created: 31/May/12  Updated: 11/Jul/16  Resolved: 31/May/12

Status: Closed
Project: Core Server
Component/s: Aggregation Framework
Affects Version/s: 2.1.1
Fix Version/s: 2.1.2

Type: Improvement Priority: Major - P3
Reporter: Chris Westin Assignee: Chris Westin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

When I did the original implementation of DocumentSourceSort, there was some issue with using a vector<> of documents. Mathias spotted this in his initial scan of the code. So I went back to see what the problem was. Whatever it was, it's gone, and using a vector<> works now. This is clearly better (because it can internally do something like a qsort()), so I made the change.

Work is already done and tested (was trivial), so I marked it for 2.1.2; will get it through code review.



 Comments   
Comment by auto [ 31/May/12 ]

Author:

{u'login': u'cwestin', u'name': u'U-tellus\\cwestin', u'email': u'cwestin@10gen.com'}

Message: SERVER-5977; fix indentation as per code review
Branch: master
https://github.com/mongodb/mongo/commit/b8bff69057ff01df7a0e81017d304c6ae50ecaa0

Comment by auto [ 31/May/12 ]

Author:

{u'login': u'cwestin', u'name': u'U-tellus\\cwestin', u'email': u'cwestin@10gen.com'}

Message: SERVER-5977; use vector instead of list
Branch: master
https://github.com/mongodb/mongo/commit/610eb7840cbd073d499c9d2c6eff2b1bba5ba973

Generated at Thu Feb 08 03:10:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.