[SERVER-59841] Consider whether ownership should be enforced by the IDL for owned types Created: 08/Sep/21  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: James Wahlin Assignee: Backlog - Query Optimization
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-69915 Consider calling getOwned for object_... Backlog
is related to SERVER-59204 unowned filter BSONObj stored in Plan... Closed
Assigned Teams:
Query Optimization
Participants:

 Description   

As part of working onĀ SERVER-59204 we discovered that the FindCommandRequest IDL structure does not enforce that certain members like "filter" are actually owned, despite having type "object_owned_nonempty_serialize". We should consider whether it makes sense to enforce ownership in the IDL for owned types. If we do enforce then changes would include:

1) Making default empty objects owned. For the "filter" field mentioned above, a query that is parsed with no filter will result in an empty object, which are not considered owned despite having no associated buffer.

2) Making setters call BSONObj::getOwned() on input arguments



 Comments   
Comment by Joe Kanaan [ 09/Sep/21 ]

If this is recurring, please put this back up for triage.

Generated at Thu Feb 08 05:48:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.