[SERVER-59927] Resharding's RecipientStateMachine::_restoreMetrics() doesn't retry on transient errors, leading to fassert() on stepdown Created: 13/Sep/21 Updated: 29/Oct/23 Resolved: 12/Oct/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 5.0.0 |
| Fix Version/s: | 5.2.0, 5.0.4, 5.1.0-rc1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Max Hirschhorn | Assignee: | Brett Nawrocki |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | PM-234-M3, PM-234-T-lifecycle | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v5.1, v5.0
|
||||||||||||||||||||
| Sprint: | Sharding 2021-09-20, Sharding 2021-10-04, Sharding 2021-10-18 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Story Points: | 1 | ||||||||||||||||||||
| Description |
|
The changes from fee0349 as part of As a bonus on this ticket, we should see if it is possible to have the resharding code invariant that all usages of CancelableOperationContextFactory occur within a resharding::WithAutomaticRetry() block.
|
| Comments |
| Comment by Githook User [ 18/Oct/21 ] |
|
Author: {'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}Message: RecipientStateMachine::_restoreMetrics() performs a number of read Furthermore, refactor RecipientStateMachine to use new Additionally, add a test case that will cover the _restoreMetrics() read (cherry picked from commit b9e2784da82fef8e45b95b88e4ac1443649a5b0c) |
| Comment by Githook User [ 18/Oct/21 ] |
|
Author: {'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}Message: RecipientStateMachine::_restoreMetrics() performs a number of read Furthermore, refactor RecipientStateMachine to use new Additionally, add a test case that will cover the _restoreMetrics() read (cherry picked from commit b9e2784da82fef8e45b95b88e4ac1443649a5b0c) |
| Comment by Githook User [ 11/Oct/21 ] |
|
Author: {'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}Message: RecipientStateMachine::_restoreMetrics() performs a number of read Furthermore, refactor RecipientStateMachine to use new Additionally, add a test case that will cover the _restoreMetrics() read |