[SERVER-60027] Avoid makePromiseFuture in future_util.h Created: 16/Sep/21  Updated: 29/Oct/23  Resolved: 17/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2021-10-04
Participants:
Linked BF Score: 35
Story Points: 1

 Description   

The structured bindings use here is causing some toolchains to emit an error:

src/mongo/util/future_util.h:569:10: error: structured binding refers to incomplete class type 'mongo::PromiseAndFuture<void>' [-Werror]

It's unclear why this is happening exactly but maybe future_util.h doesn't need to use structured binding or PromiseAndFuture at all.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 17/Sep/21 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-60027 avoid makePromiseFuture in future_util
Branch: master
https://github.com/mongodb/mongo/commit/d18734dcf759b3c43d93664934f6711a5c0e47bc

Comment by Billy Donahue [ 16/Sep/21 ]

trivial

Generated at Thu Feb 08 05:48:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.