[SERVER-60062] Fix duplicate uuid and server description deep copy found in topology description clone Created: 17/Sep/21  Updated: 29/Oct/23  Resolved: 21/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.10, 5.0.4, 5.1.0-rc0

Type: Bug Priority: Minor - P4
Reporter: Lamont Nelson Assignee: Lamont Nelson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
is related to SERVER-57451 TopologyDescription::clone should mak... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0, v4.4
Participants:
Linked BF Score: 135

 Description   

When the RSM's topology manager creates a new TopologyDescription it clones the previous description and makes modifications to this clone. The topology description contains a uuid field that is used to aid debugging. We have observed two descriptions published by the topology manager that have the same uuid. While it is possible that this might occur, it's highly unlikely according to the guarantees offered by UUIDs and suggests a bug. This should be fixed such that any clone contains a probabilistically unique id.

Additionally, the server descriptions should be copied as well. The clone on TopologyDescription should have deep copy semantics.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 22/Sep/21 ]

Author:

{'name': 'LaMont Nelson', 'email': 'lamont.nelson@mongodb.com', 'username': 'lamontnelson'}

Message: SERVER-60062 Fix cloning of server description and uuid in RSM's topology description

(cherry picked from commit ed6372937bb6d10c440f016333ed41ccb67e9139)
Branch: v4.4
https://github.com/mongodb/mongo/commit/75ea17705d4e385f12b0a7b576e03359c23d6982

Comment by Githook User [ 22/Sep/21 ]

Author:

{'name': 'LaMont Nelson', 'email': 'lamont.nelson@mongodb.com', 'username': 'lamontnelson'}

Message: SERVER-60062 Fix cloning of server description and uuid in RSM's topology description

(cherry picked from commit ed6372937bb6d10c440f016333ed41ccb67e9139)
Branch: v5.0
https://github.com/mongodb/mongo/commit/5774796d96234dab385f7bd19edd67f3d2f1db4c

Comment by Githook User [ 21/Sep/21 ]

Author:

{'name': 'LaMont Nelson', 'email': 'lamont.nelson@mongodb.com', 'username': 'lamontnelson'}

Message: SERVER-60062 Fix cloning of server description and uuid in RSM's topology description
Branch: master
https://github.com/mongodb/mongo/commit/ed6372937bb6d10c440f016333ed41ccb67e9139

Generated at Thu Feb 08 05:48:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.