[SERVER-60141] Upgrade timelib to 2021.09 or later Created: 22/Sep/21 Updated: 29/Oct/23 Resolved: 26/Sep/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Query Execution |
| Affects Version/s: | None |
| Fix Version/s: | 6.0.3, 6.2.0-rc0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Mohammad Dashti (Inactive) | Assignee: | Alberto Massari |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | timelib | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v6.0, v5.0, v4.4
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | QE 2022-01-10, QE 2022-02-07, QE 2022-02-21, QE 2022-01-24, QE 2022-09-19, QE 2022-10-03 | ||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
As part of We expect this change gets included in timelib 2021.09. This upgrade will make sure that we don't have to maintain any custom change from timelib by ourselves. |
| Comments |
| Comment by Githook User [ 25/Oct/22 ] |
|
Author: {'name': 'Alberto Massari', 'email': 'alberto.massari@mongodb.com', 'username': 'albymassari'}Message: |
| Comment by Alberto Massari [ 26/Sep/22 ] |
|
The new timelib library fixes a bug in the computation of the week day for dates before 1 A.D.. This affects dayOfWeek, isoDayOfWeek, week and dateDiff(.."week"..). These years should not be used in real case scenarios, though |
| Comment by Githook User [ 26/Sep/22 ] |
|
Author: {'name': 'Alberto Massari', 'email': 'alberto.massari@mongodb.com', 'username': 'albymassari'}Message: |
| Comment by Kyle Suarez [ 02/Mar/22 ] |
|
This ticket got lost on the backlog; flagging for retriage. |
| Comment by Mohammad Dashti (Inactive) [ 30/Sep/21 ] |
|
david.storch I agree with you. I'll put it back in the backlog. We need to reschedule it once a new release of timelib becomes available. |
| Comment by David Storch [ 29/Sep/21 ] |
|
I don't see a huge rush to get 2021b or any other particular version of the tz db into the embedded copy of the tz data in mongod. Users can always use --timeZoneInfo if they need a different version of the tz db. I think we can put this ticket back in the triage queue, and preferably mark it so that it can be revisited in a quarter or so. It seems overall easier to just stay in sync with timelib and allow Derick to cut timelib releases at his natural cadence. We just have to remember to upgrade the vendored copy of timelib regularly so that we don't fall behind! |
| Comment by Mohammad Dashti (Inactive) [ 28/Sep/21 ] |
|
Also, here's another reply from Derick on https://github.com/derickr/timelib/pull/117
Then, there's nothing to be updated for now. I'll move this ticket to the "Blocked" state. We can also close it for now and re-open it later. |
| Comment by Mohammad Dashti (Inactive) [ 28/Sep/21 ] |
|
david.storch I opened a ticket for this this: https://github.com/derickr/timelib/issues/118 Here's the response from Derick:
Then, I don't see it happening soon. Do you think we should wait for it? |
| Comment by David Storch [ 28/Sep/21 ] |
|
There is also a recent 2021b release of the IANA timezone db: https://www.iana.org/time-zones. We should make sure that the embedded version of the timezone db is at least 2021b when we do this work. |