[SERVER-60175] Opt-in to -Wdeprecated Created: 23/Sep/21  Updated: 27/Dec/22  Resolved: 16/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Alex Neben
Resolution: Won't Fix Votes: 0
Labels: post-c++20
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-72231 Complete TODO listed in SERVER-60175 Closed
Assigned Teams:
Server Development Platform
Participants:

 Description   

Clang doesn't enable it by default under -Wall, but we would definitely like those diagnostics. We will first need to resolve SERVER-60173.



 Comments   
Comment by Alex Neben [ 16/Dec/22 ]

src/third_party/boost/boost/multiprecision/cpp_int.hpp:523:96: error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated]
const std::size_t cpp_int_base<MinBits, MaxBits, signed_magnitude, Checked, Allocator, false>::limb_bits; 

Boost (one of many errors)

In file included from src/third_party/mozjs/extract/js/src/jit/MoveResolver.h:13:
src/third_party/mozjs/extract/js/src/jit/RegisterSets.h:297:13: warning: definition of implicit copy assignment operator for 'TypedRegisterSet<js::jit::FloatRegister>' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
  constexpr TypedRegisterSet(const TypedRegisterSet<T>& set) 

mozjs

The main problem is the boost error that cannot be opted out of. For this reason I don't think it matters too much to have this flag. These will become errors as we upgrade this just pushes the errors forward.

Generated at Thu Feb 08 05:49:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.