[SERVER-6018] Replace AtomicUInt with AtomicUInt32 Created: 06/Jun/12  Updated: 18/Aug/14  Resolved: 05/Aug/14

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.7.5

Type: Improvement Priority: Minor - P4
Reporter: Andy Schwerin Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-5648 Improved support for native AtomicUInt64 Closed
related to SERVER-13913 Provide implementation of AtomicWord<... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

The interface of AtomicUInt32 is more clearly defined, and has portable semantics. It should replace AtomicUInt.



 Comments   
Comment by Githook User [ 05/Aug/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Replace AtomicUInt with AtomicUInt32
Branch: master
https://github.com/mongodb/mongo/commit/931f48190b276dd783d76ae4071228d6ab1f0bfd

Comment by Githook User [ 04/Aug/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Remove unused _initCounter functions

These functions are unused, but depend on the deprecated AtomicUInt type.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/e64ffe7b0d6601d64069a3af95fc05382c8a91e4

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 SERVER-13913 Make AtomicWord objects non-copyable and non-movable
Branch: master
https://github.com/mongodb/mongo/commit/87b350a0eeafb6a7933e9be3ffc453b690741653

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 SERVER-13913 Use std::atomic to implement AtomicWord in C++11 mode
Branch: master
https://github.com/mongodb/mongo/commit/3c202ac893db05e2486efd4a384c6bb49f01831f

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 The MSGID type doesn't need to be atomic
Branch: master
https://github.com/mongodb/mongo/commit/ab600c4056f13ee7dc49899bd76be4a8898b3360

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Replace AtomicUInt with AtomicUInt32 in SSLManager
Branch: master
https://github.com/mongodb/mongo/commit/5b3f117641dee72eac36f2d86f16aef3ad6f33a7

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Replace AtomicUInt with AtomicUInt32 in DBClientConnection
Branch: master
https://github.com/mongodb/mongo/commit/84cb300c5315a88782fe841c2e47e902190a36b9

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Replace AtomicUInt with AtomicUInt32 in connpool
Branch: master
https://github.com/mongodb/mongo/commit/545d8d8420d7cf7f25514cf8b2ec1cabfbda6747

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Replace AtomicUInt with AtomicUInt32 in OID
Branch: master
https://github.com/mongodb/mongo/commit/41d8623717159868eb952ae44cde8f8d3d1e6b52

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Use AtomicUInt32 instead of old AtomicUint in the BSONObj::Holder ref counter

This reverts commit 4c5319c46f492f00a39ded6f056151ec650abb54 (which was itself a revert),
and then removes some questionable debugging logic.

Conflicts:
src/mongo/bson/bsonobj.h
Branch: master
https://github.com/mongodb/mongo/commit/ed505aa5f1d386eb8f4109e3506345e98b798049

Comment by Githook User [ 18/May/14 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-6018 Use gcc __sync primitives if they are available and useable
Branch: master
https://github.com/mongodb/mongo/commit/1134c0d1fc3dcbde6a457ecd55de1697d7a13f97

Comment by auto [ 07/Jun/12 ]

Author:

{u'login': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: Revert "SERVER-6018: Use AtomicUInt32 instead of old AtomicUint in the BSONObj::Holder ref counter."

This reverts commit fb3dab498a111382df1dbfab99c8392c1b55822e. It just needs to bake longer.
Branch: master
https://github.com/mongodb/mongo/commit/4c5319c46f492f00a39ded6f056151ec650abb54

Comment by auto [ 07/Jun/12 ]

Author:

{u'login': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: SERVER-6018: Use AtomicUInt32 instead of old AtomicUint in the BSONObj::Holder ref counter.
Branch: master
https://github.com/mongodb/mongo/commit/fb3dab498a111382df1dbfab99c8392c1b55822e

Comment by auto [ 07/Jun/12 ]

Author:

{u'login': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: Revert "SERVER-6018: Use AtomicUInt32 instead of old AtomicUint in the BSONObj::Holder ref counter."

This reverts commit 171b237832b7f5422b9dce7ce9130d523192abb0, build break.
Branch: master
https://github.com/mongodb/mongo/commit/b5eab3d57098c48853b718ea98efa94c0b02843f

Comment by auto [ 07/Jun/12 ]

Author:

{u'login': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: SERVER-6018 Use AtomicUInt32 instead of old AtomicUInt in dbtests/threadedtests.
Branch: master
https://github.com/mongodb/mongo/commit/27fe29cefe90f46a99533209e606f9663f213530

Comment by auto [ 07/Jun/12 ]

Author:

{u'login': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: SERVER-6018: Use AtomicUInt32 instead of old AtomicUint in the BSONObj::Holder ref counter.
Branch: master
https://github.com/mongodb/mongo/commit/171b237832b7f5422b9dce7ce9130d523192abb0

Generated at Thu Feb 08 03:10:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.