[SERVER-60193] find_flip_sbe_enabled.js FSM workload never actually runs any tests Created: 23/Sep/21  Updated: 29/Oct/23  Resolved: 14/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc1

Type: Improvement Priority: Minor - P4
Reporter: David Storch Assignee: Jennifer Peshansky (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.1
Sprint: QE 2021-10-18
Participants:

 Description   

The find_flip_sbe_enabled.js FSM workload, first introduced under SERVER-56729, was designed to test that queries can continue to run correctly even if the flag to enable/disable SBE is concurrently being flipped on and off. Since the test turns SBE on, we have some checks to make it so that the test only runs under configurations where SBE is already enabled – the idea being that we don't ever want to turn SBE on in a build variant where SBE is supposed to be enabled.

However, this check is implemented incorrectly in such a way that causes the test to do nothing. At the beginning of the test during the setup phase, there is logic to explicitly disable SBE. Each of the functions representing an FSM state subsequently check whether SBE is enabled, and if so bail out (for example, see here). But because the test just disabled SBE, we end up bailing from every FSM state function. As a result, the test does nothing.

I think we can fix this by simply no longer explicitly disabling SBE at the beginning of the test.



 Comments   
Comment by Githook User [ 14/Oct/21 ]

Author:

{'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}

Message: SERVER-60193 Robustify find_flip_sbe_enabled.js

(cherry picked from commit c5f902b4d98e75a6bbb92b9ec52913a95209644d)
Branch: v5.1
https://github.com/mongodb/mongo/commit/71aea74cab64514c5fae024753c0c6fc1ffc7bce

Comment by Githook User [ 13/Oct/21 ]

Author:

{'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}

Message: SERVER-60193 Robustify find_flip_sbe_enabled.js
Branch: master
https://github.com/mongodb/mongo/commit/115f935ab4cb1b8ba96077c40fcbdad42662e470

Comment by Kyle Suarez [ 13/Oct/21 ]

jennifer.peshansky, it looks like the commit for this ticket was reverted, so I'm re-opening this issue.

Comment by Githook User [ 12/Oct/21 ]

Author:

{'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}

Message: SERVER-60193: Revert "SERVER-60193 Robustify find_flip_sbe_enabled.js"
Branch: master
https://github.com/mongodb/mongo/commit/2e9edd836eaf872f3f30077e3ee22c79578705df

Comment by Githook User [ 12/Oct/21 ]

Author:

{'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}

Message: SERVER-60193 Robustify find_flip_sbe_enabled.js
Branch: master
https://github.com/mongodb/mongo/commit/fbf03c7611f11c0d89496085e74f66a8f10f44d6

Generated at Thu Feb 08 05:49:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.