[SERVER-60229] lock manager for mongos Created: 26/Sep/21  Updated: 27/Oct/23  Resolved: 31/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Backlog - Storage Execution Team
Resolution: Gone away Votes: 0
Labels: techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-26879 Get rid of LockerNoop Closed
Related
related to SERVER-77613 Complete TODO listed in SERVER-60229 Closed
is related to SERVER-59591 LockerNoop::isW() always returns true... Closed
is related to SERVER-42901 Use LockerImpl for the startup code p... Closed
is related to SERVER-59618 Avoid using LockerNoop outside of uni... Closed
is related to SERVER-77353 Get rid of the Locker implementation ... Closed
Assigned Teams:
Storage Execution
Sprint: Execution Team 2021-11-15, Execution Team 2022-01-24
Participants:

 Description   

mongos currently runs without a full featured resource lock manager. OperationContext instances are created with LockerNoop for the lock implementation, which has sometimes led to issues such as those described in SERVER-59591.

This ticket looks into whether it makes sense to install a lock manager for mongos with a lock implementation closer to that in LockerImpl.



 Comments   
Comment by Kaloian Manassiev [ 31/May/23 ]

No need for that after SERVER-77353

Comment by Benety Goh [ 12/Nov/21 ]

We were trying to avoid issues such as those found in SERVER-59591. In SERVER-59618, we cloned LockerNoop into LockerMongos, which still returns true for Locker::isNoop().

I am not aware of any recent Locker issues with mongos, so this ticket is more of a proactive effort to head off potential issues with using a LockerNoop-derived class for mongos.

We can revisit this ticket at a later time.

Comment by Kaloian Manassiev [ 29/Sep/21 ]

What is the use case for a lock manager on MongoS? Is it about taking advantage of the resource mutexes? Because MongoS itself doesn't have notion of the locking hierarchy.

Generated at Thu Feb 08 05:49:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.