[SERVER-60245] Reduce RecordId copying in hot code paths Created: 27/Sep/21  Updated: 29/Oct/23  Resolved: 15/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0

Type: Improvement Priority: Major - P3
Reporter: Louis Williams Assignee: Louis Williams
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-10-18, Execution Team 2021-11-01
Participants:
Linked BF Score: 100

 Description   

SERVER-58949 increased the size of RecordId from 16 bytes to 32 and added a ConstSharedBuffer member that made the type no longer trivially copiable.

This caused some performance regressions in hot code paths. Reduce the number of RecordId copies required in these code paths by passing references and moving where able.

These hot paths include, but are not limited to: validation, index builds, and collection scans



 Comments   
Comment by Githook User [ 15/Oct/21 ]

Author:

{'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}

Message: SERVER-60245 Reduce RecordId copying in classic query engine collection scans
This also makes minor improvements in RecordId comparison and `isValid()` functions
Branch: master
https://github.com/mongodb/mongo/commit/2119cbfd590aa667b5ee3d4b3b2a331cc4d58486

Generated at Thu Feb 08 05:49:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.