[SERVER-60363] Make assertion for amount of retries in ocsp_retry_backoffs.js less specific Created: 30/Sep/21  Updated: 29/Oct/23  Resolved: 05/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0, 5.1.0-rc3

Type: Task Priority: Major - P3
Reporter: Erwin Pe Assignee: Erwin Pe
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.1
Sprint: Security 2021-10-04, Security 2021-10-18
Participants:
Linked BF Score: 44

 Description   

The assertion: checkLog.checkContainsWithCountJson(conn, FETCH_LOG_ID, {}, 5) is too specific and doesn't take into account the time between the mongod process start until the mongo shell connection is accepted, which may happen slowly (e.g. 8 seconds in the BF). Within this 8 seconds, there have already been 5 fetch retries, so when the script sleeps for an additional 10 seconds, another fetch occurs bringing the number of fetches to 6, thus causing an assertion failure.

The assertion needs to change to something like checkLog.containsWithAtLeastCount(conn, msg, 5).



 Comments   
Comment by Githook User [ 29/Oct/21 ]

Author:

{'name': 'Erwin Pe', 'email': 'erwin.pe@mongodb.com', 'username': 'erwee'}

Message: SERVER-60363 Make assertion for amount of retries in ocsp_retry_backoffs less specific

(cherry picked from commit df815b97b49dd4385299447a880df6f6a66bffb0)
Branch: v5.1
https://github.com/mongodb/mongo/commit/650e442154e12eb2631504c1c9e9059ceae1f7b3

Comment by Erwin Pe [ 28/Oct/21 ]

This needs to be backported to 5.1 because it fixes a 5.1 BF that should be resolved before the 5.1 release, so that the release team has less minor BFs to worry about..

Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 05/Oct/21 ]

Author:

{'name': 'Erwin Pe', 'email': 'erwin.pe@mongodb.com', 'username': 'erwee'}

Message: SERVER-60363 Make assertion for amount of retries in ocsp_retry_backo…
Branch: master
https://github.com/mongodb/mongo/commit/df815b97b49dd4385299447a880df6f6a66bffb0

Generated at Thu Feb 08 05:49:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.