[SERVER-60388] ShardingWriteRouter GBenchmark Doesn't Utilize registerClientObserver Created: 01/Oct/21  Updated: 29/Oct/23  Resolved: 01/Oct/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Luis Osta (Inactive) Assignee: Luis Osta (Inactive)
Resolution: Fixed Votes: 0
Labels: sharding
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-60691 benchmark_main does not register Clie... Closed
is related to SERVER-58960 Measure the overhead from ShardingWri... Closed
is related to SERVER-59618 Avoid using LockerNoop outside of uni... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2021-10-04
Participants:
Linked BF Score: 70

 Description   

Recently, an invariant was added to require a locker instance. It was done for SERVER-59618.

We need to add a line before creating the operation context in the benchmarks to register the client observer. Such as:

    auto serviceContext = ServiceContext::make();
    const auto client = serviceContext->makeClient("test");
    serviceContext->registerClientObserver(std::make_unique<LockerMongosClientObserver>());
 
    const auto opCtx = client->makeOperationContext();



 Comments   
Comment by Githook User [ 14/Oct/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: Revert "SERVER-60388 benchmark_main registers LockerNoopClientObserver with ServiceContext"

This reverts commit 10d9f10ea2c88a99a18ab7261501a24708b878cf.
Branch: master
https://github.com/mongodb/mongo/commit/74f672aee4380f63ff8053ffe18f1c50fd7ce83c

Comment by Githook User [ 14/Oct/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-60388 benchmark_main registers LockerNoopClientObserver with ServiceContext
Branch: master
https://github.com/mongodb/mongo/commit/10d9f10ea2c88a99a18ab7261501a24708b878cf

Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 01/Oct/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-60388 Update ShardingWriteRouter GBenchmark to utilize registerClientObserver
Branch: master
https://github.com/mongodb/mongo/commit/16682cbb1eacfd5fc80d07582105938cd5cb5e91

Generated at Thu Feb 08 05:49:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.