[SERVER-60426] Spurious rebuilds of the intel decimal library when using SCons Created: 04/Oct/21 Updated: 29/Oct/23 Resolved: 23/Mar/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Dev Platform 2022-03-07, Dev Platform 2022-03-21, Dev Platform 2022-04-04 |
| Participants: |
| Description |
|
It seems that the fix for |
| Comments |
| Comment by Githook User [ 21/Mar/22 ] | ||||||||||||||||||
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: | ||||||||||||||||||
| Comment by Daniel Moody [ 15/Mar/22 ] | ||||||||||||||||||
|
acm yeah if I can repro it, I should be able to discover the details of exactly whats happening and form a better solution. Thanks! | ||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 15/Mar/22 ] | ||||||||||||||||||
|
This reproduces for me every time on macOS with the following SCons invocation:
After every run, I see it pulling state from cache:
Now, there is a lot going on in that build, so I validated that I can see the same thing on linux with a simpler build:
Again, on re-running that command a second time, I see the intel library get rebuilt:
But, and here is a critical insight: if I drop the --implicit-cache flag, this issue goes away:
Meanwhile, if I take out the call to add_to_implicit in src/third_party/IntelRDFPMathLib20U1/SConscript, the issue goes away (after one more spurious rebuild, with subsequent builds always up to date), even if I use --implicit-cache. I didn't realize that --implicit-cache was necessary to see this issue when I filed it. I almost always use that flag since it does significantly speed up pure SCons builds. Maybe the interaction between --implicit-cache and the call to add_to_implicit as a necessary setup for observing these rebuilds is enough to point to a root cause. Do you want to take the ticket back to pursue that angle? |