[SERVER-60569] Clean up the OpObserver unittest TestFundamentalOnDeleteOutputs Created: 08/Oct/21 Updated: 29/Oct/23 Resolved: 27/Oct/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0, 5.1.2 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Daniel Gottlieb (Inactive) | Assignee: | Daniel Gottlieb (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Participants: | |||||
| Linked BF Score: | 65 | ||||
| Description |
|
In particular, the test claims to exercise passing in different StoreDocOption, but those are not part of the input. In theory, that variable was to control whether OplogDeleteEntryArgs.deletedDoc should have a value when calling onDelete. In practice the RetryableOptions is sufficient to express the cases we're interested in. Sharing code between the delete test case inputs and the update test case inputs is probably to blame. |
| Comments |
| Comment by Githook User [ 29/Nov/21 ] |
|
Author: {'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}Message: Notably remove an unused test case input from the delete variation. (cherry picked from commit 89ed05447616745bb25433126bb4a458258c9bda) |
| Comment by Githook User [ 27/Oct/21 ] |
|
Author: {'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}Message: Notably remove an unused test case input from the delete variation. |