[SERVER-60584] Write a test to ensure SBE's implementation of multiply succeeds in edge cases Created: 08/Oct/21 Updated: 29/Oct/23 Resolved: 27/Oct/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0, 5.1.0-rc3 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Jennifer Peshansky (Inactive) | Assignee: | Jennifer Peshansky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v5.1
|
||||||||||||
| Sprint: | QE 2021-10-18, QE 2021-11-01 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
This is a follow-up to BF-22891. It seems that this is actually a classic engine bug and We could try calling $multiply with 2 args and 3 args with every possible combination of types. We should test very small and very large values: 1, 2^32, 2^32-1, -1, as well as the limits of each of the types that may cause an overflow. Here's a repro of one failure, the one that occurred in the original BF: In the v5.1 shell, this results in: In the v5.0 shell, however, it triggers an error: "Can't coerce out of range value -9.8696e+34 to long." |
| Comments |
| Comment by Githook User [ 01/Nov/21 ] |
|
Author: {'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}Message: |
| Comment by Githook User [ 27/Oct/21 ] |
|
Author: {'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}Message: |