[SERVER-60585] Update uses of sliceMerge in the codebase to not refer to "slice" Created: 08/Oct/21  Updated: 29/Oct/23  Resolved: 07/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Mathis Bessa
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Server Serverless 2021-10-11, Server Serverless 2021-10-18, Server Serverless 2021-10-25
Participants:

 Description   

We decided to stop using the term "slice", so we should remove uses of "slice" from the codebase.

We could instead say "merge" or "tenantMerge", e.g. for the feature flag gSliceMerge we could say gMerge or gTenantMerge.

$ git grep -i  sliceMerge
jstests/auth/lib/commands_lib.js:const isSliceMergeEnabled = TestData.setParameters.featureFlagSliceMerge;
jstests/auth/lib/commands_lib.js:              protocol: isSliceMergeEnabled ? "slice merge" : "multitenant migrations",
jstests/replsets/libs/tenant_migration_util.js:     * Returns true if feature flag 'featureFlagSliceMerge' is enabled, false otherwise.
jstests/replsets/libs/tenant_migration_util.js:    function isSliceMergeEnabled(db) {
jstests/replsets/libs/tenant_migration_util.js:        const flagDoc = admin.runCommand({getParameter: 1, featureFlagSliceMerge: 1});
jstests/replsets/libs/tenant_migration_util.js:        return flagDoc.hasOwnProperty("featureFlagSliceMerge") &&
jstests/replsets/libs/tenant_migration_util.js:            flagDoc.featureFlagSliceMerge.value &&
jstests/replsets/libs/tenant_migration_util.js:                                           flagDoc.featureFlagSliceMerge.fcv) >= 0;
jstests/replsets/libs/tenant_migration_util.js:        if (isSliceMergeEnabled(db)) {
jstests/replsets/libs/tenant_migration_util.js:        isSliceMergeEnabled,
jstests/replsets/slice_merge_enabled.js: * @tags: [requires_fcv_51, featureFlagSliceMerge]
jstests/replsets/slice_merge_enabled.js:    assert(TenantMigrationUtil.isSliceMergeEnabled(adminDB));
jstests/replsets/slice_merge_enabled.js:runFeatureFlagMultiversionTest('featureFlagSliceMerge', runTest);
src/mongo/db/commands/tenant_migration_donor_cmds.cpp:                MigrationProtocolEnum::kSliceMerge) {
src/mongo/db/commands/tenant_migration_donor_cmds.cpp:                        repl::feature_flags::gSliceMerge.isEnabled(
src/mongo/db/commands/tenant_migration_donor_cmds.idl:            kSliceMerge: "slice merge"
src/mongo/db/repl/repl_server_parameters.idl:    featureFlagSliceMerge:
src/mongo/db/repl/repl_server_parameters.idl:        cpp_varname: feature_flags::gSliceMerge
src/mongo/tla_plus/SliceMerge/MCSliceMerge.cfg:\* Config file to run the TLC model-checker on SliceMerge.tla.
src/mongo/tla_plus/SliceMerge/MCSliceMerge.cfg:\* See SliceMerge.tla for instructions.
src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:---- MODULE MCSliceMerge ----
src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:\* This module defines MCSliceMerge.tla constants/constraints for model-checking.
src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:EXTENDS SliceMerge
src/mongo/tla_plus/SliceMerge/SliceMerge.tla:----------------------------- MODULE SliceMerge -----------------------------
src/mongo/tla_plus/SliceMerge/SliceMerge.tla:\* To run the model-checker, first edit the constants in MCSliceMerge.cfg if desired,
src/mongo/tla_plus/SliceMerge/SliceMerge.tla:\*     ./model-check.sh SliceMerge



 Comments   
Comment by A. Jesse Jiryu Davis [ 20/Oct/21 ]

I've set fixVersion to 5.2.0.

Comment by Mathis Bessa [ 19/Oct/21 ]

jesse Thank you, I forgot to do this last night. I moved it to "done" which required to remove the "backlog" field. 
If this is the wrong status please let me know and I will fix accordingly.

Comment by A. Jesse Jiryu Davis [ 19/Oct/21 ]

mathis.bessa should this ticket be closed?

Comment by Githook User [ 15/Oct/21 ]

Author:

{'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}

Message: SERVER-60585 - Update uses of sliceMerge in the codebase to not refer
Branch: master
https://github.com/mongodb/mongo/commit/1da53c1901d6f4335ccc196c5e649b3687a4a3a9

Comment by Mathis Bessa [ 11/Oct/21 ]

Note : Per latest slack conversation it was decided to go with 

  • shardMerge/Split 

in order to keep the tenancy connotation implied by using the term "slice".

Comment by Suganthi Mani [ 08/Oct/21 ]

Note: another possible option is  gShard[Split|Merge].

Generated at Thu Feb 08 05:50:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.