[SERVER-6071] Use command on local.slaves instead of cursor Created: 11/Jun/12 Updated: 10/Nov/15 Resolved: 22/Jul/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kristina Chodorow (Inactive) | Assignee: | Matt Dannenberg |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
This requires changing code on the primary, so I don't think we can do this. The primary uses a _slaves map to track where the slaves are synced to. This map is only updated by calling getMore() for registered oplog-tailing cursors. Upshot: _slaves isn't changed if you call local.slaves.update(), therefore w doesn't work. |
| Comments |
| Comment by auto [ 09/Aug/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by auto [ 08/Aug/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by auto [ 08/Aug/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by auto [ 05/Aug/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by auto [ 31/Jul/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: removed unnecessary fsyncLock and "local" lock from bgsync where it pertained to SyncSourceFeedback |
| Comment by auto [ 24/Jul/13 ] |
|
Author: {u'username': u'tadmarshall', u'name': u'Tad Marshall', u'email': u'tad@10gen.com'}Message: Branch: master |
| Comment by auto [ 22/Jul/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: rearranged locking to prevent deadlocks |
| Comment by auto [ 22/Jul/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: Revert "Revert " This reverts commit 6486b4035c5ac52679eb3e1a034c925ccdd20deb. |
| Comment by auto [ 13/Jul/13 ] |
|
Author: {u'username': u'tadmarshall', u'name': u'Tad Marshall', u'email': u'tad@10gen.com'}Message: Branch: master |
| Comment by auto [ 12/Jul/13 ] |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: Revert " This reverts commit 2267744af0e972bceccb4ff4e9ed19a1ed639d2e. Revert " This reverts commit 85ca38c33e4aaebad539e78a05aed329b09c1208. Conflicts: Revert " This reverts commit 83ecb9775b7997dd5115c53f6ea30d2e368a4244. Conflicts: |
| Comment by auto [ 01/Jul/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: fixed a bug where we would have to wait for a command to timeout on a dead syncsource |
| Comment by auto [ 30/Jun/13 ] |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: |
| Comment by auto [ 30/Jun/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'Matt Dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by Eric Milkie [ 14/Jun/13 ] |
|
backport possibly to 2.4. |
| Comment by Eliot Horowitz (Inactive) [ 17/May/13 ] |
|
Command would be fine. |
| Comment by Eric Milkie [ 16/May/13 ] |
|
How about using a command instead? Avoids locking the local database. |
| Comment by Eric Milkie [ 05/Mar/13 ] |
|
This will help write concern latency since secondaries will be more accurate/timely in reporting where they are in the oplog. |
| Comment by Kristina Chodorow (Inactive) [ 11/Jun/12 ] |
|
Looks like this changed here: |