[SERVER-60723] Fix a bug with how sbe::bson::convertFrom() computes the size of a BinData Created: 14/Oct/21  Updated: 29/Oct/23  Resolved: 15/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0, 5.1.0-rc1

Type: Bug Priority: Major - P3
Reporter: Drew Paroski Assignee: Drew Paroski
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.1
Participants:

 Description   

The logic for handling BinDatas in sbe::bson::convertFrom() differs from what sbe::value::copyValue() does. I carefully read through how the BinData type is described at bsonspec.org and I looked at how BinData is implemented in the classic execution engine, and it appears that the logic for handling BinDatas in sbe::bson::convertFrom() is wrong and that sbe::value::copyValue()'s implementation is correct.

The goals of this task is to update how sbe::bson::convertFrom() handles BinDatas to match what sbe::value::copyValue() does.



 Comments   
Comment by Githook User [ 18/Oct/21 ]

Author:

{'name': 'Drew Paroski', 'email': 'drew.paroski@mongodb.com', 'username': 'paroski'}

Message: SERVER-60723 Fix a bug with how sbe::bson::convertFrom() computes the size of a BinData

(cherry picked from commit e77eda3f09dcd2be820b1f1eec7ce8ac6c0cf477)
Branch: v5.1
https://github.com/mongodb/mongo/commit/438be46f68c838ebeb801cf746cf10e2e263968a

Comment by Githook User [ 15/Oct/21 ]

Author:

{'name': 'Drew Paroski', 'email': 'drew.paroski@mongodb.com', 'username': 'paroski'}

Message: SERVER-60723 Fix a bug with how sbe::bson::convertFrom() computes the size of a BinData
Branch: master
https://github.com/mongodb/mongo/commit/e77eda3f09dcd2be820b1f1eec7ce8ac6c0cf477

Generated at Thu Feb 08 05:50:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.