[SERVER-60899] Add new 5.0 language features to stable API Created: 21/Oct/21  Updated: 29/Oct/23  Resolved: 30/Mar/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Charlie Swanson Assignee: Joel Redman (Inactive)
Resolution: Fixed Votes: 0
Labels: auto-reverted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Documented
is documented by DOCS-15193 Investigate changes in SERVER-60899: ... Closed
Problem/Incident
Related
is related to SERVER-58962 Remove require_fcv_51 from api_versio... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.3, v5.0
Sprint: QO 2022-01-24, QO 2022-02-07, QO 2022-02-21, QO 2022-03-07, QO 2022-03-21, QO 2022-04-04
Participants:
Linked BF Score: 178

 Description   

Features like the following were excluded from API v1 in SERVER-58076. We should consider marking them as stable, now that it's been a quarter. That list:

  • $dateTrunc
  • $dateAdd
  • $dateSubtract
  • $dateDiff
  • $setWindowFields
  • $getField
  • $setField

Also worth mentioning: $tsSeconds and $tsIncrement also made it into 5.1, not 5.0 (barely): SERVER-56873



 Comments   
Comment by Joel Redman (Inactive) [ 28/Mar/22 ]

Need to port to 5.0, 5.2, and maybe 5.3

Comment by Githook User [ 28/Mar/22 ]

Author:

{'name': 'Joel Redman', 'email': 'joel.redman@mongodb.com', 'username': 'joredman'}

Message: SERVER-60899 Add time expressions and window functions to V1
Branch: master
https://github.com/mongodb/mongo/commit/44682e01ffd32f3c2a893b8ee88f2b174bcd8ada

Comment by xgen-buildbaron-user [ 22/Mar/22 ]

Ticket re-opened due to revert. aggregation began a consistent failure of jstests\aggregation\sources\setWindowFields\exclude_from_api_version_1.js

Comment by Githook User [ 22/Mar/22 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-60899 Add new time expressions and original window functions to V1"

This reverts commit 0f9843968b1656cd1287d33f16508368fd5d7b2a.
Branch: master
https://github.com/mongodb/mongo/commit/14eb8da788f85dd6d702da95ef450e8c2a6ac68b

Comment by Githook User [ 21/Mar/22 ]

Author:

{'name': 'Joel Redman', 'email': 'joel.redman@mongodb.com', 'username': 'joredman'}

Message: SERVER-60899 Add new time expressions and original window functions to V1
Branch: master
https://github.com/mongodb/mongo/commit/0f9843968b1656cd1287d33f16508368fd5d7b2a

Comment by Kyle Suarez [ 18/Nov/21 ]

I believe what Charlie means is that, when we add new features, like new expressions, they are initially excluded from API Version 1. Now that one quarter has passed and we believe their semantics are correct and stable, we should now include them in API Version 1 by removing this kNeverInVersion1 option: https://github.com/mongodb/mongo/blob/ca9bb0300c804617e936c2e2516b441a9474e355/src/mongo/db/pipeline/expression.cpp#L7428-L7430

Comment by Ana Meza [ 18/Nov/21 ]

charlie.swanson we are unsure of the request here, could you please provide further details or triage it on the NAMER side?

Thanks

Generated at Thu Feb 08 05:51:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.