|
I am closing this ticket as I think this fix is not necessary. And, we should allow tenant migration tests to run in multi-version test suites which runs mix binary versions in a replica set but not mix FCV replica sets. (note: We have agreed that Merge will be compatible across different binary versions but not across different FCVs”
For Future Reference:
SERVER-60963 was mainly created to tackle BF-23098 (in multi-version test suites).
- I did notice that the main issue in that BF was that the new "protocol" field added to the tenant migration state document in donor and recipient wasn't guarded by FCV. As a result when the donor and recipient replica set was run in mix-binary versions, the secondaries on the lower binary version couldn't recognize the "protocol" field during the oplog application and made the server to crash. (Initial plan is to address this problem in a separate ticket, but now since the original commit has been reverted, the fix for it will included as part of
SERVER-59495).
- Since there were many tests failed in that multi-version test suites, I was under a wrong assumption that in the multi-version test suites, we run mix FCV replica sets, i.e, donor on 5.2 and recipient on 5.0, causing recipient to receive 'recipientSyncData' cmd with protocol field, leading to build failures. Since, multi-version test suites don't run mix FCV replica sets, we no longer need this PR.
(Raw notes: Multi-version test suites either run (last-lts, latest) or (last-continuous, latest) mix-binary versions combo. FCV will be decided by resmoke and will be always the lowest binary version, either last-lts or last-continuous depends on which combo it is testing)
|