[SERVER-60970] Compile Error in C++20 mode with GCC 11 if MONGO_COMPILER_NOINLINE is Used on Builder::_growReallocate() Created: 25/Oct/21  Updated: 29/Oct/23  Resolved: 09/Nov/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0

Type: Question Priority: Major - P3
Reporter: Mohammad Dashti (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2021-11-15
Participants:
Linked BF Score: 64

 Description   

benety.goh added this commit, which was based on the suggestions on the Evergreen job. However, it's not clear why this limitation exists. The Builder::_growReallocate() method should not be inlined in any of its call sites. Can you please check the reason and whether it's possible to keepĀ MONGO_COMPILER_NOINLINE on this method?



 Comments   
Comment by Githook User [ 09/Nov/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-60970 Apply some small fixups to builder
Branch: master
https://github.com/mongodb/mongo/commit/be11dc126adc61121e8d8bb5da1e7e3874da7d41

Comment by Githook User [ 08/Nov/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-60970 BufBuilder slow path for grow should be out of line
Branch: master
https://github.com/mongodb/mongo/commit/c12e2c00cafb7d8f0ffcf5ff196ae4d7d530a773

Comment by Githook User [ 04/Nov/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-60970 Repair and extend explicit instantiations for BSON builders
Branch: master
https://github.com/mongodb/mongo/commit/20549d58943b586749d1570eee834c71bdef1b37

Comment by Mathias Stearn [ 26/Oct/21 ]

It may be worth doing a patch build to put the annotation back on with the new 3-pointer implementation. The new implementation of grow, may be enough to make this issue go away.

Comment by Mohammad Dashti (Inactive) [ 25/Oct/21 ]

Here is the link to the failed Evergreen build: https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_enterprise_rhel80_dynamic_v4gcc_cxx20_debug_experimental_compile_dist_test_d7a4c99472599e63b6e1f9cdb66008bb3a99bacd_21_10_21_03_07_52/0?type=T

Generated at Thu Feb 08 05:51:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.