[SERVER-60987] Add comment in all PrimaryOnlyServices that don't utilize 'existingInstances' Created: 26/Oct/21  Updated: 29/Oct/23  Resolved: 15/Nov/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Didier Nadeau
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

SERVER-60752 passed a vector of 'existingInstances' on a new PrimaryOnlyService instance's construction, to allow each service to first check if there are any conflicting instances.

However, pre-existing services have already implemented conflict detection their own ways, so don't utilize 'existingInstances.'

It will help future readers to add a comment to this effect in the pre-existing services.



 Comments   
Comment by Githook User [ 15/Nov/21 ]

Author:

{'name': 'Didier Nadeau', 'email': 'didier.nadeau@mongodb.com', 'username': 'nadeaudi'}

Message: SERVER-60987 Add comment to primary-only-service instances that don't utilize instance conflict check
Branch: master
https://github.com/mongodb/mongo/commit/4d1cb079a497ca7f7ce56a3f7d798d0ffd122cfd

Comment by Esha Maharishi (Inactive) [ 08/Nov/21 ]

didier.nadeau it'd be nice to keep changes that are logically separate in separate PR's/commits, but sometimes it makes sense to roll a small unrelated change into an existing PR. This one could go either way, since both tickets are pretty straightforward - up to you.

Comment by Didier Nadeau [ 08/Nov/21 ]

esha.maharishi Is it ok to merge this task with SERVER-60990 (which also concerns the conflict detection logic) ?

Generated at Thu Feb 08 05:51:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.