[SERVER-60990] PrimaryOnlyService shouldn't check for conflicting instances when rebuilding instances on stepup Created: 26/Oct/21 Updated: 29/Oct/23 Resolved: 11/Nov/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Didier Nadeau |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Server Serverless 2021-11-15 |
| Participants: |
| Description |
|
However, constructInstance is called in both PrimaryOnlyService::getOrCreateInstance and PrimaryOnlyService::_rebuildInstances. There's no need to check for conflicting instances in _rebuildInstances, so we pass an empty 'existingInstances' vector. Instead, we should make a separate method 'checkIfConflictsWithOtherInstances' that is only called on getOrCreateInstance. |
| Comments |
| Comment by Githook User [ 11/Nov/21 ] |
|
Author: {'name': 'Didier Nadeau', 'email': 'didier.nadeau@mongodb.com', 'username': 'nadeaudi'}Message: |