[SERVER-60999] Coverity analysis defect 121065: Parse warning Created: 26/Oct/21  Updated: 27/Oct/23  Resolved: 02/Nov/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Suganthi Mani
Resolution: Gone away Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: ALL
Sprint: Server Serverless 2021-11-01, Server Serverless 2021-11-15
Participants:

 Description   

Parse warning

A parse warning may reduce maintainability of the code, or it may indicate a serious error. A parse warning from the Coverity parser may indicate a bug, or poor coding practice
/src/mongo/db/repl/tenant_migration_recipient_service.cpp:2492: PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE 121065 type qualifier on return type is meaningless



 Comments   
Comment by Suganthi Mani [ 02/Nov/21 ]

Addressed the issue in this  commit.

Comment by Max Hirschhorn [ 26/Oct/21 ]

The changes from 56a5ddb as part of SERVER-59495 were reverted. FYI suganthi.mani for when you'd go to re-commit the changes.

2492
const MigrationProtocolEnum TenantMigrationRecipientService::Instance::getProtocol() const {
2493
    return _protocol;
2494
}

https://github.com/mongodb/mongo/commit/99f4696e26b26a33902067d2f3b71b053413b4ab#diff-57c95ee64f74deeeccc9368f93016a72112942c7675b8d10b5efec61bfa0c53dL2495

Generated at Thu Feb 08 05:51:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.