[SERVER-61012] Instantiation of TEMPLATE rule sometimes has a command in generated ninja Created: 26/Oct/21 Updated: 29/Oct/23 Resolved: 09/Nov/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0, 5.1.2, 5.0.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v5.1, v5.0
|
||||
| Sprint: | Dev Platform 2021-11-01, Dev Platform 2021-11-15 | ||||
| Participants: | |||||
| Description |
|
The TEMPLATE rule doesn't care about your `cmd` value:
But if you have a stanza like this in your SCons:
It ends up in the `cmd` stanza of the sole invocation of the `TEMPLATE` rule:
This is harmless, since TEMPLATE isn't going to honor it, but it is confusing when reading the generated ninja file and is probably something we should avoid doing. |
| Comments |
| Comment by Githook User [ 29/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 8c0afec60c1dc85eed55494a886d59652c98c869) |
| Comment by Githook User [ 29/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 8c0afec60c1dc85eed55494a886d59652c98c869) |
| Comment by Githook User [ 09/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: |