[SERVER-61105] The sessions migration logic during moveChunk pollutes the logs Created: 29/Oct/21 Updated: 29/Oct/23 Resolved: 06/Jan/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0, 5.0.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Matt Boros |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | sharding-nyc-subteam1 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v5.2, v5.0
|
||||||||||||
| Sprint: | Sharding 2021-12-27, Sharding 2022-01-10 | ||||||||||||
| Participants: | |||||||||||||
| Story Points: | 2 | ||||||||||||
| Description |
|
The sessions migration logic during moveChunk logs every time it finishes draining the active sessions with retryable writes on them. This means that on a system, which doesn't have retryable writes for example or where the catch-up of the actual chunk data finishes slightly earlier than the sessions being drained (such as for example with multi-writes), it will log every few milliseconds a log line like this:
This is wasteful both from logging perspective and from the fact that it actively polls the donor shard with useless calls. It would be good if some form of long-polling is implemented so that the donor is not queried actively if there are no sessions, but even if that is not implemented, at least the logging should happen only on transitions to "finished draining" rather than every time. |
| Comments |
| Comment by Githook User [ 06/Jan/22 ] |
|
Author: {'name': 'Matt Boros', 'email': 'matt.boros@mongodb.com'}Message: (cherry picked from commit 8e681e80447e5859f79296e10911ffec39f31efa) |
| Comment by Githook User [ 06/Jan/22 ] |
|
Author: {'name': 'Matt Boros', 'email': 'matt.boros@mongodb.com'}Message: (cherry picked from commit 8e681e80447e5859f79296e10911ffec39f31efa) |
| Comment by Githook User [ 06/Jan/22 ] |
|
Author: {'name': 'Matt Boros', 'email': 'matt.boros@mongodb.com'}Message: |
| Comment by Max Hirschhorn [ 22/Nov/21 ] |
|
Acceptance criteria:
|