[SERVER-61144] Finish importing donated collections on secondaries Created: 30/Oct/21  Updated: 29/Oct/23  Resolved: 07/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Task Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: Christopher Caplinger
Resolution: Fixed Votes: 0
Labels: shard-merge-milestone-1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-61134 Call voteCommitMigrationProgress with... Closed
is depended on by SERVER-63830 Coverity analysis defect 121565: Unin... Closed
is depended on by SERVER-59492 Post-Merge cleanup Closed
is depended on by SERVER-61141 Create TenantMigrationRecipientAccess... Closed
is depended on by SERVER-61145 Start fetching donor oplog entries Closed
is depended on by SERVER-62934 Don't require donor fsync before shar... Closed
is depended on by SERVER-63119 Write unit tests for class TenantFile... Closed
is depended on by SERVER-63120 Handle recipient secondary failures w... Closed
is depended on by SERVER-63204 Delete the temp db path on the recipi... Closed
is depended on by SERVER-63390 Abort merge on error from OpObserver ... Closed
is depended on by SERVER-63697 Remove "copied files" state and step,... Closed
is depended on by SERVER-63789 Don't block recipient oplog applicati... Closed
Duplicate
is duplicated by SERVER-62054 Link file-copy and rollback-to-stable... Closed
Backwards Compatibility: Fully Compatible
Sprint: Server Serverless 2022-02-21, Server Serverless 2022-03-07
Participants:

 Description   

See design doc for details. This ticket should include actually importing donor files on secondaries (current code only runs on primary).



 Comments   
Comment by Githook User [ 24/Feb/22 ]

Author:

{'name': 'Christopher Caplinger', 'email': 'christopher.caplinger@mongodb.com', 'username': 'UnicodeSnowman'}

Message: SERVER-61144: Finish importing donated collections on secondaries
Branch: master
https://github.com/mongodb/mongo/commit/972d3f082e84c82002c15b9ad3bbed05d77db514

Comment by Suganthi Mani [ 02/Feb/22 ]

christopher.caplinger Couple of suggestions that I missed adding while reviewing the wiredTigerImportFromBackupCursor()
1) Before moving the files from temp db path to actual db path, add a sanity check that the file name doesn't exist in the target (i.e) actual db path. This would prevent any accidental data corruption.
2) Nit: print the migration id when printing the import related log message, here and here, for easy debugging.

CC jesse

Generated at Thu Feb 08 05:51:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.