[SERVER-61249] refine_collection_shard_key_basic.js relies on a best-effort refresh that might not happen in case of failover Created: 04/Nov/21  Updated: 29/Oct/23  Resolved: 15/Dec/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.4.14, 5.3.0, 5.0.7, 4.4.15

Type: Task Priority: Major - P3
Reporter: Jordi Serra Torrens Assignee: Jordi Serra Torrens
Resolution: Fixed Votes: 0
Labels: sharding-product-sync, sharding-wfbf-sprint
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.0, v4.4
Sprint: Sharding EMEA 2022-01-10
Participants:
Linked BF Score: 28

 Description   

In refine_collection_shard_key_basic.js, we refine the shard key and then wait for the shards to discover the new collection epoch.
In absence of a mongoS that discovers the new epoch and then queries the shards with that shardVersion, the shard would only discover the new epoch through this best-effort refresh triggered at the end of _configsvrRefineCollectionShardKey. In stepdown suites, this refresh might fail.

refine_collection_shard_key_basic.js should either:
1. Not test this particular condition (at least, on stepdown suites)
2. Ensure that the shards discover the new shard version by having a mongos first see it and having it query the shards with it.



 Comments   
Comment by Githook User [ 04/May/22 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-61249 Skip test case in refine_collection_shard_key_basic.js that relies on a best-effort shard refresh

(cherry picked from commit a3741453e5c602514b1b9554e236792204ab907e)
(cherry picked from commit 581dc1ab9dfb0677a8ea27be6c697f3311f4ba20)
Branch: v4.4
https://github.com/mongodb/mongo/commit/4ddd9320a29a5e453ea07c0f3d780fc29afa1336

Comment by Githook User [ 22/Feb/22 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-61249 Skip test case in refine_collection_shard_key_basic.js that relies on a best-effort shard refresh

(cherry picked from commit a3741453e5c602514b1b9554e236792204ab907e)
Branch: v5.0
https://github.com/mongodb/mongo/commit/581dc1ab9dfb0677a8ea27be6c697f3311f4ba20

Comment by Githook User [ 15/Dec/21 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-61249 Skip test case in refine_collection_shard_key_basic.js that relies on a best-effort shard refresh
Branch: master
https://github.com/mongodb/mongo/commit/a3741453e5c602514b1b9554e236792204ab907e

Comment by Connie Chen [ 13/Dec/21 ]

The work in this ticket is to remove the lines that are checking the best effort refresh. (i.e. option #1)

Comment by Kaloian Manassiev [ 12/Nov/21 ]

We want to make it resilient to crashes and as part of the coordinator we need to ensure that the shard refreshes. We think this work will take one iteration to complete.

Generated at Thu Feb 08 05:51:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.