[SERVER-61288] idl_check_compatibility.py parses older version command idl files using files imported from master source Created: 05/Nov/21  Updated: 29/Oct/23  Resolved: 09/Nov/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0

Type: Bug Priority: Major - P3
Reporter: Suganthi Mani Assignee: Suganthi Mani
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-59495 Update recipient state machine depend... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Server Serverless 2021-11-15
Participants:

 Description   

idl_check_compatibility.py parses older version command idl files using files imported from master source. This can lead to false alarm like below

 
[2021/11/04 21:08:46.398] Performing idl check compatibility with release: idls/r5.1.0:
[2021/11/04 21:08:46.398] Errors found while compiling IDL
[2021/11/04 21:08:46.398] serverless_types.idl: (35, 8): ID0002: enum 'MigrationProtocol' is a duplicate symbol of an existing enum
[2021/11/04 21:08:46.398] Found 1 errors
[2021/11/04 21:08:46.398] Traceback (most recent call last):
[2021/11/04 21:08:46.398]   File "/data/mci/b0981df248ca885979d6548b41b25947/src/buildscripts/idl/idl_check_compatibility.py", line 1105, in <module>
[2021/11/04 21:08:46.399]     main()
[2021/11/04 21:08:46.399]   File "/data/mci/b0981df248ca885979d6548b41b25947/src/buildscripts/idl/idl_check_compatibility.py", line 1086, in main
[2021/11/04 21:08:46.399]     error_coll = check_compatibility(args.old_idl_dir, args.new_idl_dir, args.include)
[2021/11/04 21:08:46.399]   File "/data/mci/b0981df248ca885979d6548b41b25947/src/buildscripts/idl/idl_check_compatibility.py", line 975, in check_compatibility
[2021/11/04 21:08:46.399]     raise ValueError(f"Cannot parse {old_idl_file_path}")
[2021/11/04 21:08:46.399] ValueError: Cannot parse idls/r5.1.0/src/mongo/db/commands/tenant_migration_donor_cmds.idl
[2021/11/04 21:08:46.414] Command failed: error waiting on process 'ade6532a-2f94-4ff1-9ea9-1eca713d57a2': exit status 1
[2021/11/04 21:08:46.558] Task completed - FAILURE.
[2021/11/04 21:08:46.584] Running post-task commands.



 Comments   
Comment by Githook User [ 09/Nov/21 ]

Author:

{'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}

Message: SERVER-61288 idl_check_compatibility.py parses older version command idl files using files imported from the same older version branch.
Branch: master
https://github.com/mongodb/mongo/commit/b154ad3dfabf4903a550fbb68abca94d276a81cf

Generated at Thu Feb 08 05:52:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.