[SERVER-61358] validate cachedir incorrectly re-raising InvalidChecksum Created: 09/Nov/21  Updated: 29/Oct/23  Resolved: 11/Nov/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2.0, 5.1.2, 5.0.6

Type: Bug Priority: Major - P3
Reporter: Daniel Moody Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.1, v5.0
Sprint: Dev Platform 2021-11-15
Participants:
Linked BF Score: 29

 Description   

The validate cachedir has a try-except block around a file being removed out from under it. It catches this case and should just return a state of non retrieval from the cache, and the build should be able to continue to success.

 

However an incorrect use of the 'finally' causes an exception to be re-raised during the normal handling of the original exception in the try-except block. This finally should be an else block instead.



 Comments   
Comment by Githook User [ 29/Nov/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-61358 fix cachedir handling of file being removed out from under the build.

(cherry picked from commit 524581bfe2291d929ded715c3f33188f8a0dd36d)
Branch: v5.1
https://github.com/mongodb/mongo/commit/088a70fe6937fe11015479d02c87a27ea4ba8b84

Comment by Githook User [ 29/Nov/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-61358 fix cachedir handling of file being removed out from under the build.

(cherry picked from commit 524581bfe2291d929ded715c3f33188f8a0dd36d)
Branch: v5.0
https://github.com/mongodb/mongo/commit/de513ba99a979c4a51ef438b85765d91f7a82313

Comment by Githook User [ 10/Nov/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-61358 fix cachedir handling of file being removed out from under the build.
Branch: master
https://github.com/mongodb/mongo/commit/524581bfe2291d929ded715c3f33188f8a0dd36d

Generated at Thu Feb 08 05:52:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.