[SERVER-61358] validate cachedir incorrectly re-raising InvalidChecksum Created: 09/Nov/21 Updated: 29/Oct/23 Resolved: 11/Nov/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0, 5.1.2, 5.0.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Moody | Assignee: | Daniel Moody |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v5.1, v5.0
|
||||||||
| Sprint: | Dev Platform 2021-11-15 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 29 | ||||||||
| Description |
|
The validate cachedir has a try-except block around a file being removed out from under it. It catches this case and should just return a state of non retrieval from the cache, and the build should be able to continue to success.
However an incorrect use of the 'finally' causes an exception to be re-raised during the normal handling of the original exception in the try-except block. This finally should be an else block instead. |
| Comments |
| Comment by Githook User [ 29/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 524581bfe2291d929ded715c3f33188f8a0dd36d) |
| Comment by Githook User [ 29/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: (cherry picked from commit 524581bfe2291d929ded715c3f33188f8a0dd36d) |
| Comment by Githook User [ 10/Nov/21 ] |
|
Author: {'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}Message: |