[SERVER-61655] Last point TS Opt M3: TSBS performance test update Created: 19/Nov/21  Updated: 29/Oct/23  Resolved: 11/Apr/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: New Feature Priority: Major - P3
Reporter: Ruslan Abdulkhalikov (Inactive) Assignee: Alya Berciu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File TSBS_lastpoint_optimized.png     PNG File TSBS_lastpoint_unoptimized.png     PNG File lastpoint_tsbs_improvement.png    
Issue Links:
Depends
depends on SERVER-57592 Enable Feature flag for PM-2330 Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

Performance testing the optimization on the tsdb benchmark (last point for cpu only data).



 Comments   
Comment by Alya Berciu [ 11/Apr/22 ]

Closing as the change to the TSBS repo was merged. Note that this doesn't change server code; this only updates the TSBS query to be compatible with the lastpoint query rewrite. We expect to see an improvement >99% in TSBS lastpoint based on this patch.

Comment by Alya Berciu [ 30/Mar/22 ]

Link to PR: https://github.com/gregorynoma/tsbs/pull/11
Evergreen patch confirming that the DISTINCT_SCAN optimization is picked up: https://spruce.mongodb.com/version/62386c96a4cf475427ab799e/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Note that we are not running TSBS on the all-feature-flags variant in the sys-perf waterfall; however, for my tests I uncommented that task in evergreen.yml

EDIT: I attached screenshots of the difference in metrics with and without the lastpoint optimization.

Note further that the query rewrite will cause the query to fail with a "sort exceeded memory limit" exception when the flag is disabled. This means that the PR linked above cannot be merged until the lastpoint flag is enabled by default.

Generated at Thu Feb 08 05:52:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.