[SERVER-61690] Adjust stored fields protocol for atlas search Created: 22/Nov/21 Updated: 29/Oct/23 Resolved: 01/Dec/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.0, 5.1.2, 5.0.6, 4.4.11 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Ted Tuckman |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v5.1, v5.0, v4.4
|
||||||||||||||||||||||||
| Sprint: | QO 2021-12-13 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
After going through syntax review, it was determined we'd name the stored fields under 'storedSource' rather than just 'stored', so we'll have to adjust the protocol accordingly. It was also determined that _id could be excluded (optionally), so we should add some testing for that. I don't see anything in particular that will break based on my reading of the original patch for |
| Comments |
| Comment by Githook User [ 06/Dec/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Ted Tuckman', 'email': 'ted.tuckman@mongodb.com', 'username': 'TedTuckman'}Message:
(cherry-picked from commit 2f83c0184dfc3dff1ef4cdba30d4629f29f28d5c) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 03/Dec/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Ted Tuckman', 'email': 'ted.tuckman@mongodb.com', 'username': 'TedTuckman'}Message:
(cherry-picked from commit 304b5f763305d06b04b96e2bc782eecb073fb0a7) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 03/Dec/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Ted Tuckman', 'email': 'ted.tuckman@mongodb.com', 'username': 'TedTuckman'}Message:
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 01/Dec/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Author: {'name': 'Ted Tuckman', 'email': 'ted.tuckman@mongodb.com', 'username': 'TedTuckman'}Message: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Alexander Lukyanchikov [ 22/Nov/21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
To clarify, with this change logic on mongod side can be simplified. If returnStoredSource is set to true in the query, mongot will always return top-level "storedSource" field, but won't return top-level "_id". The expectation is that mongod would just return "storedSource" as is to the end user without any modifications. Note that "storedSource" might not contain _id and also can be empty. A few examples for a query with returnStoredSource:true:
|