|
The source has changed since this defect was created. When I rewound my local git copy to Nov 24, the source looked like this around line 59:
// TODO (SERVER-61138): Record collections' metadata.
|
conn->close(conn, nullptr);
|
// TODO (SERVER-61143): Import collections into main WT instance.
|
So I think Coverity was sad about dereferencing conn without checking it for null. The code for wiredTigerRollbackToStableAndGetMetadata() is different now and is protected against calling close against a null conn.
|
|
This is confusing to me. The new code that Coverity dislikes is:
WT_CURSOR* cursor;
|
uassertWTOK(
|
session->open_cursor(session,
|
"{}{}"_format(WiredTigerKVEngine::kTableUriPrefix, ident).c_str(),
|
nullptr,
|
nullptr,
|
&cursor));
|
But there's lots of cases where we pass nullptr for the 3rd and 4th params of open_cursor, e.g. here. What's Coverity complaining about?
|