[SERVER-61801] Clarify tasserts in the exception architecture guide Created: 30/Nov/21  Updated: 29/Oct/23  Resolved: 19/Oct/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Josef Ahmad Assignee: Alex Li
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-62595 Migrate logv2/README.md to docs/loggi... Closed
related to SERVER-63184 Update and combine docs/logging.md an... Needs Scheduling
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-10-17, Service Arch 2022-10-31
Participants:

 Description   

The exception architecture guide implies that a tassert is for user errors, while a tassert is actually for programmer errors.

"[tassert] like uassert [Checks for per-operation user errors. Operation-fatal], but inhibits clean shutdown."



 Comments   
Comment by Githook User [ 18/Oct/22 ]

Author:

{'name': 'Alex Li', 'email': 'alex.li@mongodb.com', 'username': 'lia394126'}

Message: SERVER-61801 Clarify tasserts in the exception architecture guide
Branch: master
https://github.com/mongodb/mongo/commit/0951863447a131e7df26f80a093073f573e610b1

Comment by Andy Schwerin [ 13/Jan/22 ]

There's related work in SERVER-62595 to centralize and update some information about logging.

Comment by Josef Ahmad [ 30/Nov/21 ]

billy.donahue the brackets in the description above are not suggestions. I'd just merged two sentences that are present in the architecture guide which are not accurate. Apologies for the confusion.
 
The main inaccuracy is that the guide implies tasserts identify user errors, while tasserts actually identify programmer errors. I agree that the guide can expand further on the shutdown behaviour.

Comment by Billy Donahue [ 30/Nov/21 ]

The brackets in the description above were suggestions.

We should also clarify what "inhibits clean shutdown" means. That's an inaccurate simplification of the tassert behavior.

Generated at Thu Feb 08 05:53:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.