[SERVER-61867] Clean up wire versions older than WireVersion::WIRE_VERSION_50 Created: 02/Dec/21  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Gabriel Marks Assignee: Backlog - Replication Team
Resolution: Unresolved Votes: 0
Labels: former-quick-wins
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Replication
Participants:

 Description   

The current version of mongo and onwards will never have to talk to any mongo with a wire version less than WireVersion::WIRE_VERSION_50, so checks against, tests of, and all other references to lower wire versions should be removed from the codebase.

 

Note that this is something that will crop up every time LTS changes.



 Comments   
Comment by Vishnu Kaushik [ 14/Dec/21 ]

I spoke to xuerui.fa and removing old wire versions was not a part of Minimize Per-Release Code Changes.

Some references to old wire versions in the code, such as this one in mongos, seem to be important since they make sure incompatible nodes cannot speak to the mongos.

Others in unit tests such as here can probably be replaced by a newer reference, but I don't know if there is value to doing that. We might want the old constants to stick around since there is some meaning attached to them (in the particular link above, the it denotes the new message format that is being used).

Some more uses of old wire version constants in the initial sync area are already being cleaned up in SERVER-61505.

Generated at Thu Feb 08 05:53:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.